-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement step 5 in RegExp
constructor
#3305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
enhancement
New feature or request
builtins
PRs and Issues related to builtins/intrinsics
labels
Sep 25, 2023
HalidOdat
changed the title
Implement step 5 in RegExp constructor
Implement step 5 in Sep 25, 2023
RegExp
constructor
The following step was missing from our `RegExp` constructor implementation: ``` 5. Else if patternIsRegExp is true, then a. Let P be ? Get(pattern, "source"). b. If flags is undefined, then i. Let F be ? Get(pattern, "flags"). c. Else, i. Let F be flags. ```
HalidOdat
force-pushed
the
fix/regexp-constructor
branch
from
September 25, 2023 15:34
0b15e91
to
7884ed3
Compare
Test262 conformance changes
Fixed tests (8):
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3305 +/- ##
==========================================
- Coverage 49.80% 49.80% -0.01%
==========================================
Files 441 441
Lines 43078 43083 +5
==========================================
+ Hits 21456 21457 +1
- Misses 21622 21626 +4
☔ View full report in Codecov by Sentry. |
jedel1043
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
raskad
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following step was missing from our implementation, which caused some test262 test to fail.