Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MSRV check #3291

Merged
merged 3 commits into from
Sep 24, 2023
+19 −1
Merged

Added MSRV check #3291

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
880511f
Added MSRV check
Razican Sep 20, 2023
2f217c3
Added Rust version check from Cargo.toml
Razican Sep 23, 2023
37e0547
Update rust.yml
Razican Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,24 @@ jobs:
- name: Test docs
run: cargo test --doc --profile ci --features intl

msrv:
name: Minimum supported Rust version
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
# Get the rust_version from the Cargo.toml
- name: Get rust_version
id: rust_version
run: echo "::set-output name=rust_version::$(grep '^rust-version' Cargo.toml | cut -d' ' -f3 | tr -d '"')"
Razican marked this conversation as resolved.
Show resolved Hide resolved
- uses: actions-rs/[email protected]
with:
toolchain: ${{ steps.rust_version.outputs.rust_version }}
override: true
profile: minimal
- name: Check compilation
run: cargo check --all-features --all-targets

misc:
name: Misc
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ members = [
[workspace.package]
edition = "2021"
version = "0.17.0"
rust-version = "1.71"
rust-version = "1.71.0"
authors = ["boa-dev"]
repository = "https://github.com/boa-dev/boa"
license = "Unlicense OR MIT"
Expand Down