-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rust-version
to 1.71
#3290
Conversation
Test262 conformance changes
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
=======================================
Coverage 50.31% 50.31%
=======================================
Files 436 436
Lines 42604 42604
=======================================
Hits 21438 21438
Misses 21166 21166
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thought: Would it be worthwhile adding an MSRV test to our CI as well? I feel like we typically keep pretty close to current, but it could be useful to keep track of when we should increase the version.
|
Hmmm, I think that's focused more on semver vs. msrv, right? As an example, I think |
Yeah, ignore that 😅 I was thinking that the msrv influenced semver, but I think those are orthogonal concepts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Just to ensure our repo correctly reports our MSRV for users that want to use the
main
branch.