-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix switch statement break
and continue
return values
#3205
Conversation
Test262 conformance changes
Fixed tests (10):
|
Codecov Report
@@ Coverage Diff @@
## main #3205 +/- ##
==========================================
+ Coverage 50.43% 50.44% +0.01%
==========================================
Files 436 436
Lines 42531 42544 +13
==========================================
+ Hits 21450 21461 +11
- Misses 21081 21083 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! Just some small nitpicks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me :)
This Pull Request fixes the remaining "language/statements/switch" tests with exception of the tco tests.
It changes the following:
This removes the current behaviour of setting the return value to
undefined
whenever there is abreak
orcontinue
statement at the start of a block. This was causing the return value to be unexpectedly overwritten in switch statements.Instead this is now only implemented for
catch
andfinally
blocks where this behaviour mirrors theUpdateEmpty
statements in the spec.