Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log traces even without message (boa_runtime) #3193

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

kelbazz
Copy link
Contributor

@kelbazz kelbazz commented Aug 1, 2023

This Pull Request fixes boa_runtime console.trace not printing the trace if no argument is given.

It changes the following:

  • Change the if statement scope in the trace function of Console

@jedel1043 jedel1043 added the enhancement New feature or request label Aug 3, 2023
@jedel1043 jedel1043 modified the milestones: v0.19.0, v0.18.0 Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #3193 (8a1d009) into main (5f70585) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3193   +/-   ##
=======================================
  Coverage   50.40%   50.40%           
=======================================
  Files         436      436           
  Lines       42375    42375           
=======================================
  Hits        21358    21358           
  Misses      21017    21017           
Files Changed Coverage Δ
boa_runtime/src/console/mod.rs 37.18% <0.00%> (ø)

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@jedel1043 jedel1043 requested a review from a team August 3, 2023 20:08
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Razican Razican added this pull request to the merge queue Aug 3, 2023
Merged via the queue into boa-dev:main with commit f3a0ff0 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants