-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining TypedArray bugs #3186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
labels
Jul 30, 2023
Test262 conformance changes
Fixed tests (52):
|
Codecov Report
@@ Coverage Diff @@
## main #3186 +/- ##
==========================================
+ Coverage 50.41% 50.44% +0.02%
==========================================
Files 436 436
Lines 42340 42346 +6
==========================================
+ Hits 21347 21362 +15
+ Misses 20993 20984 -9
|
HalidOdat
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! :)
jedel1043
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the remaining TypedArray bugs.
It changes the following:
Array.prototype.toString
andTypedArray.prototype.toString
.SetTypedArrayFromArrayLike
to conform to the spec.TypedArray.prototype.sort
to conform to the spec.U64OrPositiveInfinity
enum to remove some unreachable branches inTypedArray.prototype.set
.TypedArray.prototype.toLocaleString
.