Fix a Parser Idempotency Issue

[veera-sivarajan]

This PR fixes #3133 by correctly implementing ToIndentedString for with statement.

This also replaces the existing ToInternedString implementation because it is implemented for all types implementing ToIndentedString in boa_interner/src/lib.rs.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb2f33e) 44.63% compared to head (5bcaf27) 44.64%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3172   +/-   ##
=======================================
  Coverage   44.63%   44.64%           
=======================================
  Files         487      487           
  Lines       50554    50554           
=======================================
+ Hits        22563    22568    +5     
+ Misses      27991    27986    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[raskad]

Nice fix!
@veera-sivarajan do you think it makes sense to add a test for this? I think this was only discovered via fuzzing right?

[veera-sivarajan]

Yeah, this was discovered by the fuzzer but I'm not sure if it requires an additional test because the additional braces were added by how the with statement was formatted ({{}} instead of {}) in to_interned_string() which, as far as my rust-analyzer could parse, is called only by the fuzzer?

[Razican]

We should still have a test, to make sure that we don't introduce a regression in the future.

[jedel1043]

Waiting on adding the required test to merge this. @raskad will take care of that.

[jedel1043]

Thanks for the contribution!