-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypedArrayConstructors tests #3171
Conversation
Test262 conformance changes
Fixed tests (90):
|
Codecov Report
@@ Coverage Diff @@
## main #3171 +/- ##
==========================================
- Coverage 50.61% 50.53% -0.09%
==========================================
Files 444 444
Lines 42696 42767 +71
==========================================
Hits 21612 21612
- Misses 21084 21155 +71
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just some small comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
This Pull Request fixes all remaining
TypedArrayConstructors
tests.It changes the following:
drop
s to burrowedGc
s in TypedArray methods where needed.