Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1.71.0 lints #3140

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Fix 1.71.0 lints #3140

merged 2 commits into from
Jul 13, 2023

Conversation

RageKnify
Copy link
Contributor

This Pull Request fixes the lints from Rust 1.71.0

@RageKnify RageKnify requested a review from a team July 13, 2023 18:38
Razican
Razican approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a suggestion :)

boa_examples/src/bin/modulehandler.rs Outdated Show resolved Hide resolved
HalidOdat
HalidOdat approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @Razican's comment, this looks good to me! :)

@HalidOdat HalidOdat added the Internal Category for changelog label Jul 13, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Jul 13, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,858 94,858 0
Passed 74,724 74,724 0
Ignored 18,828 18,828 0
Failed 1,306 1,306 0
Panics 0 0 0
Conformance 78.77% 78.77% 0.00%

@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #3140 (d051f61) into main (e1a2bb2) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3140      +/-   ##
==========================================
- Coverage   50.68%   50.66%   -0.02%     
==========================================
  Files         444      444              
  Lines       42651    42650       -1     
==========================================
- Hits        21616    21610       -6     
- Misses      21035    21040       +5
Impacted Files Coverage Δ
boa_engine/src/context/mod.rs 54.98% <ø> (ø)
boa_engine/src/module/mod.rs 3.20% <ø> (ø)
boa_engine/src/object/builtins/jsdataview.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/modulehandler.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@jedel1043 jedel1043 added this pull request to the merge queue Jul 13, 2023
@jedel1043 jedel1043 removed this pull request from the merge queue due to a manual request Jul 13, 2023
@jedel1043 jedel1043 enabled auto-merge July 13, 2023 18:59
@jedel1043 jedel1043 added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 93d05bd Jul 13, 2023
@jedel1043 jedel1043 deleted the 1.71.0-lints branch July 13, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
Internal Category for changelog
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RageKnify @Razican @HalidOdat @jedel1043