Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Array.prototype.find* and TypedArray variants to use FindViaPredicate #3134

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Refactor Array.prototype.find* and TypedArray variants to use FindViaPredicate #3134

merged 3 commits into from
Jul 13, 2023

Conversation

dirkdev98
Copy link
Contributor

This Pull Request references #3100

It changes the following:

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #3134 (fd1af53) into main (fe9c8d9) will increase coverage by 0.03%.
The diff coverage is 45.58%.

@@            Coverage Diff             @@
##             main    #3134      +/-   ##
==========================================
+ Coverage   50.65%   50.68%   +0.03%     
==========================================
  Files         444      444              
  Lines       42661    42651      -10     
==========================================
+ Hits        21608    21617       +9     
+ Misses      21053    21034      -19
Impacted Files Coverage Δ
boa_engine/src/builtins/typed_array/mod.rs 7.53% <5.00%> (+0.05%) ⬆️
boa_engine/src/builtins/array/mod.rs 77.13% <62.50%> (+0.81%) ⬆️

... and 2 files with indirect coverage changes

@dirkdev98
Copy link
Contributor Author

Test262 conformance changes

Test result main count PR count difference
Total 94,858 94,858 0
Passed 74,724 74,724 0
Ignored 18,828 18,828 0
Failed 1,306 1,306 0
Panics 0 0 0
Conformance 78.77% 78.77% 0.00%

@dirkdev98 dirkdev98 mentioned this pull request Jul 11, 2023
Merged
HalidOdat
HalidOdat reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a nitpick :)

boa_engine/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
jedel1043
jedel1043 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

HalidOdat
HalidOdat approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Jul 13, 2023
Merged via the queue into boa-dev:main with commit e1a2bb2 Jul 13, 2023
@HalidOdat HalidOdat added technical debt Internal Category for changelog labels Jul 13, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Jul 13, 2023
@dirkdev98 dirkdev98 deleted the array-find-via-predicate branch July 13, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican left review comments

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
Internal Category for changelog technical debt
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dirkdev98 @Razican @HalidOdat @jedel1043