-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ephemeron-based weak map #3052
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #3052 +/- ##
==========================================
+ Coverage 50.40% 50.64% +0.24%
==========================================
Files 436 444 +8
Lines 42375 42746 +371
==========================================
+ Hits 21358 21649 +291
- Misses 21017 21097 +80
|
00b8bc5
to
0244e41
Compare
2f5a2e8
to
02246b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
02246b9
to
0d7c466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
This Pull Request fixes #2596 and fixes #2732.
It changes the following:
hashbrown
raw API.I only exposed
WeakMap
as public, but it would be good to decide in the future if we want to expose the fullRawWeakMap
to our users.Marking as draft since this just needs documentation and a clippy run, but it's feature complete.