-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for async module fetches #3012
Conversation
1c11684
to
9e78b2c
Compare
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
+ Coverage 47.24% 50.46% +3.21%
==========================================
Files 476 447 -29
Lines 46892 46035 -857
==========================================
+ Hits 22154 23230 +1076
+ Misses 24738 22805 -1933 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks great! :)
I will rebase this ASAP to merge this. |
b5d8f2b
to
1d93bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really useful example.
This should probably be adapted to offer a similar feature in our playground, but with more resilience against connection errors.