-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow true
, false
and null
in object patterns
#2994
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2994 +/- ##
==========================================
- Coverage 50.22% 50.15% -0.07%
==========================================
Files 446 446
Lines 46019 46030 +11
==========================================
- Hits 23114 23088 -26
- Misses 22905 22942 +37
|
It seems that there is no test for this in Test262, so we should probably add our own, and maybe add a test to Test262. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! +1 for the tests to test262, if not then our own :)
Will add both a test here and a PR on Test262, just to avoid blocking this on that PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This Pull Request allows using certain valid keywords inside patterns.