Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pseudo-property import.meta #2956

Merged
merged 2 commits into from
May 25, 2023
Merged

Implement pseudo-property import.meta #2956

merged 2 commits into from
May 25, 2023

Conversation

jedel1043
Copy link
Member

This Pull Request implements the import.meta pseudo-property.

@jedel1043 jedel1043 added enhancement New feature or request parser Issues surrounding the parser labels May 22, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone May 22, 2023
@jedel1043 jedel1043 requested a review from a team May 22, 2023 22:02
@github-actions
Copy link

github-actions bot commented May 22, 2023

Test262 conformance changes

Test result main count PR count difference
Total 93,990 93,990 0
Passed 74,614 74,620 +6
Ignored 17,622 17,622 0
Failed 1,754 1,748 -6
Panics 0 0 0
Conformance 79.39% 79.39% +0.01%
Fixed tests (6):
test/language/expressions/dynamic-import/assignment-expression/import-meta.js (previously Failed)
test/language/expressions/import.meta/import-meta-is-an-ordinary-object.js (previously Failed)
test/language/expressions/import.meta/same-object-returned.js (previously Failed)
test/language/expressions/import.meta/distinct-for-each-module.js (previously Failed)
test/language/expressions/import.meta/syntax/goal-module-nested-function.js (previously Failed)
test/language/expressions/import.meta/syntax/goal-module.js (previously Failed)

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #2956 (ecf8052) into main (09658b0) will decrease coverage by 0.14%.
The diff coverage is 22.68%.

@@            Coverage Diff             @@
##             main    #2956      +/-   ##
==========================================
- Coverage   50.15%   50.02%   -0.14%     
==========================================
  Files         446      446              
  Lines       45760    45903     +143     
==========================================
+ Hits        22951    22963      +12     
- Misses      22809    22940     +131     
Impacted Files Coverage Δ
boa_ast/src/expression/mod.rs 62.12% <0.00%> (-0.48%) ⬇️
boa_engine/src/bytecompiler/expression/mod.rs 58.06% <0.00%> (-0.55%) ⬇️
boa_engine/src/module/mod.rs 2.89% <ø> (ø)
boa_engine/src/module/source.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/code_block.rs 56.08% <ø> (ø)
boa_engine/src/vm/flowgraph/mod.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/meta/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/mod.rs 45.45% <ø> (ø)
boa_engine/src/vm/opcode/push/mod.rs 75.00% <ø> (ø)
...ser/src/parser/expression/left_hand_side/member.rs 45.13% <4.00%> (-8.20%) ⬇️
... and 2 more

... and 9 files with indirect coverage changes

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just some small nitpicks :)

boa_engine/src/vm/opcode/meta/mod.rs Show resolved Hide resolved
boa_engine/src/vm/opcode/meta/mod.rs Outdated Show resolved Hide resolved
boa_engine/src/vm/opcode/meta/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit 7ae8582 May 25, 2023
@HalidOdat HalidOdat deleted the import-meta branch May 25, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants