-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement [[HostDefined]]
field on Realm
s
#2952
Conversation
9f1907b
to
8fdc774
Compare
Test262 conformance changes
|
a869f9b
to
e39bc58
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2952 +/- ##
==========================================
- Coverage 50.31% 50.17% -0.15%
==========================================
Files 436 438 +2
Lines 42604 42730 +126
==========================================
Hits 21438 21438
- Misses 21166 21292 +126
☔ View full report in Codecov by Sentry. |
e39bc58
to
75a70a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to look at this a little deeper, but overall this looks pretty good. Just a couple questions/comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
75a70a8
to
19178bf
Compare
I redesigned the That's why It's been extended to work with as many type |
Really liking the new API! And it's also pretty similar to the upcoming Provider API (rust-lang/rust#96024), so we could migrate to that in the future without changing the API |
19178bf
to
5f1da7a
Compare
00e2cf5
to
a808420
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also like the API. Just found a few typos in the example, otherwise I'm for merging this.
- Improve HostDefined field to allow multiple stored types
a808420
to
8595932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It changes the following:
[[HostDefined]]
field toRealm
sFunctionObjectBuilder
take aRealm
instead ofContext