Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink environment binding locators #2950

Merged
merged 1 commit into from
May 21, 2023
Merged

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented May 20, 2023

Shrinks environments binding locators (which we were already doing when we truncate it to environment bytecode operands).

@HalidOdat HalidOdat added performance Performance related changes and issues execution Issues or PRs related to code execution labels May 20, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone May 20, 2023
@HalidOdat HalidOdat requested a review from a team May 20, 2023 10:00
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,982 93,982 0
Passed 73,783 73,783 0
Ignored 17,489 17,489 0
Failed 2,710 2,710 0
Panics 0 0 0
Conformance 78.51% 78.51% 0.00%

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #2950 (3db3da5) into main (fdf9444) will increase coverage by 0.00%.
The diff coverage is 80.68%.

@@           Coverage Diff           @@
##             main    #2950   +/-   ##
=======================================
  Coverage   50.39%   50.39%           
=======================================
  Files         444      444           
  Lines       45349    45350    +1     
=======================================
+ Hits        22854    22855    +1     
  Misses      22495    22495           
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/mod.rs 65.78% <ø> (ø)
...ine/src/environments/runtime/declarative/module.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/code_block.rs 55.80% <ø> (ø)
...oa_engine/src/object/internal_methods/arguments.rs 5.63% <16.66%> (ø)
boa_engine/src/bytecompiler/class.rs 15.80% <50.00%> (ø)
boa_engine/src/builtins/function/arguments.rs 96.66% <71.42%> (+0.05%) ⬆️
boa_engine/src/environments/runtime/mod.rs 76.30% <92.30%> (-0.09%) ⬇️
boa_engine/src/builtins/eval/mod.rs 64.58% <100.00%> (ø)
boa_engine/src/bytecompiler/env.rs 93.33% <100.00%> (ø)
boa_engine/src/bytecompiler/function.rs 90.90% <100.00%> (ø)
... and 11 more

@Razican Razican added this pull request to the merge queue May 21, 2023
Merged via the queue into main with commit 3f5bad7 May 21, 2023
@HalidOdat HalidOdat deleted the shrink-environment-bindings branch May 21, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution performance Performance related changes and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants