Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use_self lints #2946

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix use_self lints #2946

merged 1 commit into from
May 18, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented May 18, 2023

This Pull Request changes the following:

  • Remove allows for use_self lint
  • Fix all remaining use_self lints

@raskad raskad added the Internal Category for changelog label May 18, 2023
@raskad raskad added this to the v0.17.0 milestone May 18, 2023
@raskad raskad requested a review from a team May 18, 2023 22:40
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,982 93,982 0
Passed 73,783 73,783 0
Ignored 17,489 17,489 0
Failed 2,710 2,710 0
Panics 0 0 0
Conformance 78.51% 78.51% 0.00%

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jedel1043 jedel1043 enabled auto-merge May 18, 2023 22:53
@jedel1043 jedel1043 added this pull request to the merge queue May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #2946 (d4352f3) into main (5e9193a) will decrease coverage by 0.01%.
The diff coverage is 35.35%.

@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
- Coverage   50.39%   50.39%   -0.01%     
==========================================
  Files         443      443              
  Lines       45336    45337       +1     
==========================================
  Hits        22846    22846              
- Misses      22490    22491       +1     
Impacted Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 38.78% <0.00%> (ø)
boa_engine/src/builtins/intl/segmenter/mod.rs 7.69% <0.00%> (ø)
boa_engine/src/builtins/intl/segmenter/options.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/intl/segmenter/segments.rs 15.09% <0.00%> (ø)
...e/src/environments/runtime/declarative/function.rs 77.77% <ø> (ø)
boa_engine/src/error.rs 33.48% <ø> (ø)
boa_engine/src/lib.rs 78.20% <ø> (ø)
boa_engine/src/module/mod.rs 2.95% <0.00%> (ø)
boa_engine/src/module/source.rs 0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jspromise.rs 0.00% <0.00%> (ø)
... and 10 more

Merged via the queue into main with commit 4a368a2 May 18, 2023
@raskad raskad deleted the fix-use-self-lints branch May 18, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants