-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune collected shared shapes #2941
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 50.39% 50.42% +0.03%
==========================================
Files 443 444 +1
Lines 45337 45392 +55
==========================================
+ Hits 22846 22889 +43
- Misses 22491 22503 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it makes sense to have a test for this behaviour?
will try to add the tests, and documentation on the two prune trigger methods :) |
36d61ca
to
e2b203b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR prunes all transitions in a
SharedShape
when a transition'sWeakGc
has been garbage collected and when we insert255
properties/prototypes.Example with debug print on prune: