-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type safe root shape #2940
Merged
Merged
Type safe root shape #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2940 +/- ##
=======================================
Coverage 50.39% 50.39%
=======================================
Files 443 444 +1
Lines 45337 45349 +12
=======================================
+ Hits 22846 22854 +8
- Misses 22491 22495 +4
|
raskad
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very reasonable to me.
jedel1043
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
HalidOdat
force-pushed
the
feature/type-safe-root-shape
branch
from
May 19, 2023 03:25
e82db13
to
c3c68d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we construct a
Realm
we take aSharedShape
as the root, since users can create realms to ensure that the passed shape is the root shape (otherwise if a non-root shape is passed, will at best cause a panic and at worse will give unexpected behaviour), added theRootShape
that ensures that only a root shape is passed, this is applied to many other places where a root shape is required.It changes the following:
RootShape
wrapper aroundSharedShape
From<UniqueShape>
forShape
From<SharedShape>
forShape