Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract "About Boa" section into a separate file #2938

Merged
merged 3 commits into from
May 17, 2023
Merged

Conversation

jedel1043
Copy link
Member

This makes it easier to keep that section in sync with all crates.

@jedel1043 jedel1043 added the documentation update documentation label May 17, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone May 17, 2023
@jedel1043 jedel1043 requested a review from a team May 17, 2023 18:49
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,657 94,657 0
Passed 73,917 73,917 0
Ignored 17,505 17,505 0
Failed 3,235 3,235 0
Panics 0 0 0
Conformance 78.09% 78.09% 0.00%

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2938 (cc7f209) into main (eb37614) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2938      +/-   ##
==========================================
- Coverage   52.09%   52.06%   -0.03%     
==========================================
  Files         435      435              
  Lines       43713    43692      -21     
==========================================
- Hits        22771    22749      -22     
- Misses      20942    20943       +1     
Impacted Files Coverage Δ
boa_ast/src/lib.rs 75.00% <ø> (ø)
boa_cli/src/main.rs 0.76% <ø> (ø)
boa_engine/src/lib.rs 78.20% <ø> (ø)
boa_gc/src/lib.rs 100.00% <ø> (ø)
boa_icu_provider/src/lib.rs 100.00% <ø> (ø)
boa_interner/src/lib.rs 84.03% <ø> (ø)
boa_macros/src/lib.rs 0.00% <ø> (ø)
boa_profiler/src/lib.rs 66.66% <ø> (ø)
boa_tester/src/main.rs 0.00% <ø> (ø)
boa_unicode/src/lib.rs 66.66% <ø> (ø)
... and 1 more

... and 5 files with indirect coverage changes

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit ab87b2f May 17, 2023
@HalidOdat HalidOdat deleted the common-about branch May 17, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants