-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix switch default
execution
#2907
Conversation
Test262 conformance changes
Fixed tests (10):
|
f425a18
to
5d63cf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just got a typo :)
Codecov Report
@@ Coverage Diff @@
## main #2907 +/- ##
==========================================
- Coverage 51.88% 51.84% -0.05%
==========================================
Files 431 431
Lines 43230 43313 +83
==========================================
+ Hits 22429 22454 +25
- Misses 20801 20859 +58
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me 😄 Just one doc nitpick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄 Nice work!
Fixes switch
default
case execution, when a default case has regular switch cases below it (as in this test262 test ) we execute the default case body at the end, we should execute the cases in order.EDIT:
Fixes/closes #2405