Fix Number.prototype.toFixed()
#2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Test262 conformance changes
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
==========================================
- Coverage 49.56% 49.55% -0.01%
==========================================
Files 446 446
Lines 43716 43712 -4
==========================================
- Hits 21666 21663 -3
+ Misses 22050 22049 -1
☔ View full report in Codecov by Sentry. |
HalidOdat
force-pushed
the
fix/Number.prototype.toFixed
branch
from
aeb03e3 to
8acc2ed
Compare
HalidOdat
force-pushed
the
fix/Number.prototype.toFixed
branch
2 times, most recently
from
4d7041e to
b49041d
Compare
HalidOdat
force-pushed
the
fix/Number.prototype.toFixed
branch
from
b49041d to
c070bc5
Compare
magic-akari
reviewed
Sep 18, 2023
HalidOdat
force-pushed
the
fix/Number.prototype.toFixed
branch
from
ed757db to
6f9afcf
Compare
|
The ryu-js PR was merged, so we can publish a new version then merge this :) |
HalidOdat
force-pushed
the
fix/Number.prototype.toFixed
branch
from
6f9afcf to
4306436
Compare
HalidOdat
force-pushed
the
fix/Number.prototype.toFixed
branch
from
4306436 to
bc1eb23
Compare
|
The |
jedel1043
approved these changes
Oct 5, 2023
raskad
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2609 .
This depends on the implementation of
Number.prototype.toFixed()on boa-dev/ryu-js#35.Added the tests about the rounding (which test262 does not check) on
ryu-jsand here just in case :)