-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Disallow strict directives with escaped sequences #2892
Conversation
Test262 conformance changes
Fixed tests (2):
|
Codecov Report
@@ Coverage Diff @@
## main #2892 +/- ##
==========================================
- Coverage 51.23% 51.23% -0.01%
==========================================
Files 427 427
Lines 42520 42538 +18
==========================================
+ Hits 21787 21796 +9
- Misses 20733 20742 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! looks good to me!:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice change.
bors r+ |
This Pull Request fixes test https://github.com/tc39/test262/blob/72c0c5e16350a76bd41f7a1ceb7702588a2a39c6/test/language/directive-prologue/14.1-5-s.js by disallowing escaped sequences inside a strict directive.
Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This Pull Request fixes test https://github.com/tc39/test262/blob/72c0c5e16350a76bd41f7a1ceb7702588a2a39c6/test/language/directive-prologue/14.1-5-s.js by disallowing escaped sequences inside a strict directive.