-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update for boa_runtime and console documentation #2891
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
+ Coverage 51.23% 51.30% +0.06%
==========================================
Files 427 427
Lines 42520 42612 +92
==========================================
+ Hits 21787 21860 +73
- Misses 20733 20752 +19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me :) I would just add an extra panic so that we get notified if this fails for whatever reason.
@@ -19,7 +21,12 @@ | |||
//! ``` | |||
//! use boa_engine::{Context, Source}; | |||
//! | |||
//! let js_code = "console.log('Hello World from a JS code string!')"; | |||
//! let js_code = r#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure that we don't miss this again, I would add, in line 45, a panic (hidden with #
), so that we catch the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 😄
I think the idea is to publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Hi all!
This PR is to update the docs to ease any confusion regarding adding console to a project (RE: the discussion on discord). Feel free to let me know if there are any changes you'd like to see or if a more in depth example is needed.
I can't remember if this had been decided yet, but were we publishing
boa_runtime
? I'm wondering if it would be better to link toboajs.dev
's docs forboa_runtime
vs. the rustdoc intra-doc link.It changes the following: