Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for boa_ast::Keyword #2883

Merged
merged 2 commits into from
May 4, 2023
Merged

Added unit tests for boa_ast::Keyword #2883

merged 2 commits into from
May 4, 2023

Conversation

Razican
Copy link
Member

@Razican Razican commented Apr 30, 2023

We have a very low code coverage in our tests, and, while we have a great end-to-end testing framework setup (test262), this doesn't run unit tests for our Rust implementation.

This is the first of a series of PRs that will try to increase our code coverage so that it reaches reasonable levels.

@Razican Razican added test Issues and PRs related to the tests. ast Issue surrounding the abstract syntax tree labels Apr 30, 2023
@Razican Razican added this to the v0.17.0 milestone Apr 30, 2023
@github-actions
Copy link

github-actions bot commented Apr 30, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,601 94,601 0
Passed 73,293 73,293 0
Ignored 17,540 17,540 0
Failed 3,768 3,768 0
Panics 0 0 0
Conformance 77.48% 77.48% 0.00%

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #2883 (b2b7477) into main (c738b50) will increase coverage by 0.18%.
The diff coverage is n/a.

❗ Current head b2b7477 differs from pull request most recent head 9f9d5f8. Consider uploading reports for the commit 9f9d5f8 to get more accurate results

@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
+ Coverage   51.24%   51.42%   +0.18%     
==========================================
  Files         427      427              
  Lines       42522    42520       -2     
==========================================
+ Hits        21790    21868      +78     
+ Misses      20732    20652      -80     
Impacted Files Coverage Δ
boa_ast/src/keyword/mod.rs 100.00% <ø> (ø)

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

Just a small question

boa_ast/src/keyword/tests.rs Outdated Show resolved Hide resolved
@Razican Razican added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit 08a7238 May 4, 2023
@bors bors bot deleted the tests branch May 4, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Issue surrounding the abstract syntax tree test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants