-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Date
for dynamic timezones
#2877
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2877 +/- ##
==========================================
+ Coverage 50.91% 51.21% +0.30%
==========================================
Files 419 427 +8
Lines 41883 42503 +620
==========================================
+ Hits 21324 21768 +444
- Misses 20559 20735 +176
|
I think this will be a breaking change for @lastmjs, so I'm pinging to make sure this works for them. I'll test this later today, since I was having the mentioned issue. |
I'll see if I can test this soon |
I'm getting the following test error with this branch:
|
@Razican Pushed a change to fix the test, let me know if it works for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works now! Let's wait for @lastmjs confirmation, and we can merge it :)
I would like to test this today, I'll let you know |
Sorry for the delay, works for me! |
This Pull Request fixes #2874.
It changes the following:
HostHooks
API to correctly handle dynamic timezones.