-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Refactor binding handling APIs #2870
Conversation
Test262 conformance changes
Fixed tests (8):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes. The find binding locator mechanic seems great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! Looks good to me!
bors r+ |
We have currently some bugs related to binding assignments on arithmetic operations (`+=`, `++`, `?=`, etc.), but fixing those was getting a bit complex with our current bindings APIs. This PR refactors our binding handling APIs to be a bit easier to use.
Pull request successfully merged into main. Build succeeded: |
We have currently some bugs related to binding assignments on arithmetic operations (
+=
,++
,?=
, etc.), but fixing those was getting a bit complex with our current bindings APIs.This PR refactors our binding handling APIs to be a bit easier to use.