Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix Date.prototype[Symbol.primitive] incorrect attributes #2862

Closed
wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

Part of ES5.

This was the last failing test on Date.prototype[Symbol.primitive] test suite :)

It changes the following:

  • Fix Date.prototype[Symbol.primitive] incorrect attributes

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 23, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 23, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,591 94,591 0
Passed 73,167 73,169 +2
Ignored 17,530 17,530 0
Failed 3,894 3,892 -2
Panics 0 0 0
Conformance 77.35% 77.35% +0.00%
Fixed tests (2):
test/built-ins/Date/prototype/Symbol.toPrimitive/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/prop-desc.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2862 (5a8f191) into main (93b52cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2862   +/-   ##
=======================================
  Coverage   50.92%   50.93%           
=======================================
  Files         419      419           
  Lines       41783    41786    +3     
=======================================
+ Hits        21280    21283    +3     
  Misses      20503    20503           
Impacted Files Coverage Δ
boa_engine/src/builtins/date/mod.rs 91.74% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Razican
Copy link
Member

Razican commented Apr 23, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 23, 2023
Part of ES5.

This was the last failing test on `Date.prototype[Symbol.primitive]` test suite :)

It changes the following:

- Fix `Date.prototype[Symbol.primitive]` incorrect attributes
@bors
Copy link

bors bot commented Apr 23, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix Date.prototype[Symbol.primitive] incorrect attributes [Merged by Bors] - Fix Date.prototype[Symbol.primitive] incorrect attributes Apr 23, 2023
@bors bors bot closed this Apr 23, 2023
@bors bors bot deleted the fix/date-prototype-symbol.primitive branch April 23, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants