-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix async generators #2853
Conversation
Fixed tests (1326):
|
Codecov Report
@@ Coverage Diff @@
## main #2853 +/- ##
==========================================
- Coverage 51.11% 50.92% -0.19%
==========================================
Files 419 419
Lines 41609 41780 +171
==========================================
+ Hits 21269 21278 +9
- Misses 20340 20502 +162
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A bit of a bummer that we have to specialize some instructions for async generators, but we can try to generalize all resumable functions into a single abstraction in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me! :)
bors r+ |
Pull request successfully merged into main. Build succeeded: |
This Pull Request fixes #2711 and fixes #2671.
It changes the following:
yield
andyield*
expressions.