[Merged by Bors] - Fix PropertyKey index parse
#2843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Test262 conformance changes
Fixed tests (24): |
Codecov Report
@@ Coverage Diff @@
## main #2843 +/- ##
==========================================
+ Coverage 51.11% 51.13% +0.01%
==========================================
Files 419 419
Lines 41609 41632 +23
==========================================
+ Hits 21269 21287 +18
- Misses 20340 20345 +5
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
reviewed
Apr 19, 2023
HalidOdat
force-pushed
the
fix/property-key-index-parse
branch
from
ecdfdd0 to
f7fe0b9
Compare
Benchmark for c4093a1Click to view benchmark
|
HalidOdat
requested review from
Razican,
jasonwilliams,
RageKnify,
raskad,
jedel1043 and
nekevss
raskad
approved these changes
Apr 22, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 23, 2023
Fixes incorrect parsing of index property keys, such as: - `"+0"` is converted to an integer index `0`, should be a string - `"00"` is converted to an integer index `0`, should be a string - `"01"` is converted to an integer index `1`, should be a string
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
PropertyKey index parsePropertyKey index parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect parsing of index property keys, such as:
"+0"is converted to an integer index0, should be a string"00"is converted to an integer index0, should be a string"01"is converted to an integer index1, should be a string