[Merged by Bors] - Implement String.prototype.toLocaleUpper/LowerCase
#2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
Fixed tests (108): |
Codecov Report
@@ Coverage Diff @@
## main #2822 +/- ##
==========================================
- Coverage 51.32% 51.29% -0.03%
==========================================
Files 417 417
Lines 41356 41383 +27
==========================================
+ Hits 21224 21226 +2
- Misses 20132 20157 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
reviewed
Apr 14, 2023
raskad
reviewed
Apr 14, 2023
raskad
approved these changes
Apr 15, 2023
HalidOdat
reviewed
Apr 15, 2023
There was a problem hiding this comment.
Is there a way that we can avoid putting large binary data into git history? maybe generating this in a build.rs?
There was a problem hiding this comment.
We started with the build.rs approach on this, but it did increase compile times to much, especially in the ci. I think for now this should work. Alternativeley, we could move boa_icu_provider to a separate repository to make this easier on the git history.
Also, before looking at the size of this file, I think we should probably look at the 262 test result files on the gh-pages branch :D
There was a problem hiding this comment.
We started with the build.rs approach on this, but it did increase compile times to much, especially in the ci. I think for now this should work. Alternativeley, we could move boa_icu_provider to a separate repository to make this easier on the git history.
Yes, for the long term this seems like the a good solution.
Also, before looking at the size of this file, I think we should probably look at the 262 test result files on the gh-pages branch :D
😆 Yeah, It's big, but we could always edit the history on the gh-pages tho
There was a problem hiding this comment.
If this file doesn't change much, we might want to use git LFS: https://docs.github.com/en/repositories/working-with-files/managing-large-files/configuring-git-large-file-storage
HalidOdat
approved these changes
Apr 15, 2023
Razican
reviewed
Apr 15, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2023
This fixes some more ES5 tests that were failing because the functions haven't been implemented. It changes the following: - Adds `String::to_locale_case`, which uses ICU4X to convert strings to uppercase or lowercase. - Refactors `String::to_uppercase` and `String::to_lowercase` into a single `String::to_case` which uses a const generic to distinguish each case. - Adds utility functions on `JsString` to avoid code repetition.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
String.prototype.toLocaleUpper/LowerCaseString.prototype.toLocaleUpper/LowerCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some more ES5 tests that were failing because the functions haven't been implemented.
It changes the following:
String::to_locale_case, which uses ICU4X to convert strings to uppercase or lowercase.String::to_uppercaseandString::to_lowercaseinto a singleString::to_casewhich uses a const generic to distinguish each case.JsStringto avoid code repetition.