[Merged by Bors] - Implement async functions using generators #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
vm
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
Fixed tests (1): |
Codecov Report
@@ Coverage Diff @@
## main #2821 +/- ##
==========================================
+ Coverage 51.32% 51.36% +0.04%
==========================================
Files 417 417
Lines 41356 41258 -98
==========================================
- Hits 21224 21194 -30
+ Misses 20132 20064 -68
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
approved these changes
Apr 14, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2023
This should hopefully fix more async/futures issues related to resuming execution in the future, since we can leverage generator logic to handle this for us. It changes the following: - Refactors `GeneratorContext` to handle context preparation. - Reuses the functionality of `GeneratorContext` in `Await`. - Removes `EarlyReturnType` in favour of a single `r#await` bool flag in `CallFrame`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
Just some small improvements that increase the strictness of our generator state handling. Also rollbacks the implementation of `GeneratorValidate` because I forgot to remove it after I did modifications to #2821, and it doesn't make sense to have that if it isn't used by async functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix more async/futures issues related to resuming execution in the future, since we can leverage generator logic to handle this for us.
It changes the following:
GeneratorContextto handle context preparation.GeneratorContextinAwait.EarlyReturnTypein favour of a singler#awaitbool flag inCallFrame.