-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement HTML comments and gate behind the annex-b
feature
#2817
Conversation
Test262 conformance changes
Fixed tests (18):
|
Codecov Report
@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
+ Coverage 51.31% 51.38% +0.06%
==========================================
Files 416 417 +1
Lines 41213 41306 +93
==========================================
+ Hits 21149 21224 +75
- Misses 20064 20082 +18
... and 39 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. I think there are still some tests left that are not passing but let's get this merged and look at those after.
bors r+ |
Small steps towards ES5 conformance. This PR changes the following: - Implements HTML comments parsing (`<!--`, `-->`). - Gates the functionality behind a new `annex-b` feature for `boa_parser`. - Renames `strict_mode` to `strict` to be consistent with `Parser::set_strict`.
Pull request successfully merged into main. Build succeeded: |
annex-b
featureannex-b
feature
Small steps towards ES5 conformance.
This PR changes the following:
<!--
,-->
).annex-b
feature forboa_parser
.strict_mode
tostrict
to be consistent withParser::set_strict
.