[Merged by Bors] - Implement TryFromJs for JsObject wrappers

[Razican]

This change allows using built-in JsObject wrappers with the TryFromJs logic, which makes it easier to derive it in complex objects containing known built-ins, being able to use all the power of the wrappers even inside complex structures.

It changes the following:

• Implements TryFromJs for all JsObject wrappers , except for JsProxy and Js<Int>Array wrappers -> This has now been added.
• Adds checker functions for individual typed array objects.
• Adds some missing checker functions from Object to JsObject

The reason for not implementing it for JsProxy is that we don't have a way (as far as I can tell) to know if a JsObject is a Proxy object. The reason for the typed arrays (note that JsTypedArray implements TryFromJs) is that I didn't find an easy way to know which type of typed array a JsObject was. Do we have a way of using a JsObject to create a Rust JsUint8Array or the like?

[github-actions]

Test262 conformance changes

Test result	main count	PR count	difference
Total	94,781	94,781	0
Passed	71,403	71,403	0
Ignored	17,824	17,824	0
Failed	5,554	5,554	0
Panics	0	0	0
Conformance	75.33%	75.33%	0.00%

[codecov]

Codecov Report

Merging #2809 (50e9e1e) into main (2f580bb) will decrease coverage by 0.25%.
The diff coverage is 0.96%.

@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
- Coverage   51.31%   51.07%   -0.25%     
==========================================
  Files         416      416              
  Lines       41213    41407     +194     
==========================================
- Hits        21149    21148       -1     
- Misses      20064    20259     +195     

Impacted Files	Coverage Δ
boa_engine/src/object/builtins/jsarraybuffer.rs	0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsdataview.rs	0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsdate.rs	0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsfunction.rs	52.63% <0.00%> (-47.37%)	⬇️
boa_engine/src/object/builtins/jsgenerator.rs	0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsmap.rs	0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsmap_iterator.rs	0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jspromise.rs	0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsproxy.rs	0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsregexp.rs	0.00% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[HalidOdat]

The reason for not implementing it for JsProxy is that we don't have a way (as far as I can tell) to know if a JsObject is a Proxy object.

Wouldn't Object::is_proxy() solve this ?

The reason for the typed arrays (note that JsTypedArray implements TryFromJs) is that I didn't find an easy way to know which type of typed array a JsObject was.

I think this can be done by getting the IntegerIndexed type from ObjectKind through 'obj.data' then from IntegerIndexed get .typed_array_name which is a flat enum containing all the typed arrays kinds https://github.com/boa-dev/boa/blob/main/boa_engine/src/builtins/typed_array/mod.rs#L3503-L3516

It's not that intuitive, we should probably have helper methods

Do we have a way of using a JsObject to create a Rust JsUint8Array or the like?

We have from JsObject to JsTypedArray but not into the individial typed array kinds, seems like a useful feature that we should probably implement, I'll create an issue about it :)

[Razican]

The reason for not implementing it for JsProxy is that we don't have a way (as far as I can tell) to know if a JsObject is a Proxy object.

Wouldn't Object::is_proxy() solve this ?

Indeed, it was just not available at the JsObject level. I have made it (and others) available at this level.

The reason for the typed arrays (note that JsTypedArray implements TryFromJs) is that I didn't find an easy way to know which type of typed array a JsObject was.

I think this can be done by getting the IntegerIndexed type from ObjectKind through 'obj.data' then from IntegerIndexed get .typed_array_name which is a flat enum containing all the typed arrays kinds https://github.com/boa-dev/boa/blob/main/boa_engine/src/builtins/typed_array/mod.rs#L3503-L3516

It's not that intuitive, we should probably have helper methods

I have added them :)

Do we have a way of using a JsObject to create a Rust JsUint8Array or the like?

We have from JsObject to JsTypedArray but not into the individial typed array kinds, seems like a useful feature that we should probably implement, I'll create an issue about it :)

No need to create an issue, I have added it to this PR :)

[HalidOdat]

Looks perfect to me! :)

[raskad]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Build and Test (macos-latest)
• Build and Test (windows-latest)
• Coverage
• Misc