-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix String.prototype.substr()
#2805
Conversation
Test262 conformance changes
Fixed tests (2):
|
Codecov Report
@@ Coverage Diff @@
## main #2805 +/- ##
==========================================
- Coverage 51.30% 51.29% -0.01%
==========================================
Files 416 416
Lines 41193 41197 +4
==========================================
Hits 21133 21133
- Misses 20060 20064 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
bors r+ |
Pull request successfully merged into main. Build succeeded: |
String.prototype.substr()
String.prototype.substr()
With this and #2805 , `annex-b/builtins/string` should have 100% conformance, also fixed the `normalize` method incorrect `length` value, which was the last failing tests in `normalize` test suite
Fixes the remaining failing tests on
String.prototype.substr()
It changes the following:
substr
under the"annex-b"
feature flag.