Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix String.prototype.substr() #2805

Closed
wants to merge 2 commits into from

Conversation

HalidOdat
Copy link
Member

Fixes the remaining failing tests on String.prototype.substr()

It changes the following:

  • Fixes the remaining failing tests on `String.prototype.substr()
  • Move substr under the "annex-b" feature flag.

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 11, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 11, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,781 94,781 0
Passed 71,383 71,385 +2
Ignored 17,824 17,824 0
Failed 5,574 5,572 -2
Panics 0 0 0
Conformance 75.31% 75.32% +0.00%
Fixed tests (2):
test/annexB/built-ins/String/prototype/substr/start-and-length-as-numbers.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/substr/start-and-length-as-numbers.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #2805 (f09c45d) into main (24a4770) will decrease coverage by 0.01%.
The diff coverage is 4.00%.

@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
- Coverage   51.30%   51.29%   -0.01%     
==========================================
  Files         416      416              
  Lines       41193    41197       +4     
==========================================
  Hits        21133    21133              
- Misses      20060    20064       +4     
Impacted Files Coverage Δ
boa_engine/src/builtins/string/mod.rs 57.06% <4.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Razican
Copy link
Member

Razican commented Apr 11, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 11, 2023
Fixes the remaining failing tests on `String.prototype.substr()`

It changes the following:

- Fixes the remaining failing tests on `String.prototype.substr()
- Move `substr` under the `"annex-b"` feature flag.
@bors
Copy link

bors bot commented Apr 11, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix String.prototype.substr() [Merged by Bors] - Fix String.prototype.substr() Apr 11, 2023
@bors bors bot closed this Apr 11, 2023
@bors bors bot deleted the fix/string.prototype.substr branch April 11, 2023 04:56
bors bot pushed a commit that referenced this pull request Apr 11, 2023
With this and #2805 , `annex-b/builtins/string` should have 100% conformance, also fixed the `normalize` method incorrect `length` value, which was the last failing tests in `normalize` test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants