[Merged by Bors] - Make Realm shareable between functions
#2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
Fixed tests (40): |
Razican
approved these changes
Apr 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #2801 +/- ##
==========================================
+ Coverage 50.57% 51.41% +0.83%
==========================================
Files 415 416 +1
Lines 41207 41081 -126
==========================================
+ Hits 20841 21122 +281
+ Misses 20366 19959 -407
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
approved these changes
Apr 10, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
This Pull Request fixes #2317 and #1835, finally giving our engine proper realms 🥳. It changes the following: - Extracts the compile environment stack from `Realm` and into `Vm`. - Adjusts the bytecompiler to accommodate this change. - Adjusts `call/construct_internal` to accommodate this change. This also coincidentally fixed #2317, which I'm pretty happy about. - Adjusts several APIs (`NativeJob`, `Realm`) and builtins (`eval`, initializers) to accommodate this change. - Adjusts `JsNativeError`s to hold a reference to the Realm from which they were created. This only affects errors created within calls to function objects. Native calls don't need to set the realm because it's inherited by the next outer active function object. TLDR: `JsError` API stays the same, we just set the origin Realm of errors in `JsObject::call/construct_internal`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Realm shareable between functionsRealm shareable between functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #2317 and #1835, finally giving our engine proper realms 🥳.
It changes the following:
Realmand intoVm.call/construct_internalto accommodate this change. This also coincidentally fixed Panic while executingevalinside block inside function #2317, which I'm pretty happy about.NativeJob,Realm) and builtins (eval, initializers) to accommodate this change.JsNativeErrors to hold a reference to the Realm from which they were created. This only affects errors created within calls to function objects. Native calls don't need to set the realm because it's inherited by the next outer active function object. TLDR:JsErrorAPI stays the same, we just set the origin Realm of errors inJsObject::call/construct_internal.