-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix String.prototype.replace()
order of ToString
execution
#2799
Conversation
Test262 conformance changes
Fixed tests (4):
|
Codecov Report
@@ Coverage Diff @@
## main #2799 +/- ##
==========================================
- Coverage 50.57% 50.56% -0.01%
==========================================
Files 415 415
Lines 41207 41206 -1
==========================================
- Hits 20841 20837 -4
- Misses 20366 20369 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix and also nice optimization with the enum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+ |
Fix order of `ToString` execution, there are 3 failing tests on `.replace()` but they seem to be regex related
Pull request successfully merged into main. Build succeeded: |
String.prototype.replace()
order of ToString
executionString.prototype.replace()
order of ToString
execution
Fix order of
ToString
execution, there are 3 failing tests on.replace()
but they seem to be regex related