[Merged by Bors] - Shrink size of IndexedProperties
#2757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
performance
HalidOdat
requested review from
raskad,
Razican,
jasonwilliams,
jedel1043,
nekevss and
RageKnify
HalidOdat
changed the title
IndexedProperties
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2757 +/- ##
==========================================
+ Coverage 50.81% 51.06% +0.24%
==========================================
Files 400 396 -4
Lines 40121 39939 -182
==========================================
+ Hits 20387 20394 +7
+ Misses 19734 19545 -189
... and 17 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
approved these changes
Mar 28, 2023
jedel1043
requested changes
Mar 28, 2023
jasonwilliams
approved these changes
Mar 29, 2023
|
Good optimization |
|
Probably needs a rebase cause of #2762 |
HalidOdat
force-pushed
the
thin-indexed-properties
branch
from
024d841 to
b5ac5af
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Most objects don't have indexed properties, and those who have, have dense properties, this PR uses `ThinVec` to reduce the size of dense properties. It changes the following: - Trim `16` bytes from `IndexedProperties`, this reduces all objects size
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
IndexedPropertiesIndexedProperties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most objects don't have indexed properties, and those who have, have dense properties, this PR uses
ThinVecto reduce the size of dense properties.It changes the following:
16bytes fromIndexedProperties, this reduces all objects size