Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Make if statements return their completion values #2739

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 25, 2023

This Pull Request changes the following:

  • Adjust if statement execution to leave their resulting values on the stack when needed.

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Mar 25, 2023
@raskad raskad added this to the v0.17.0 milestone Mar 25, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,086 71,092 +6
Ignored 17,324 17,324 0
Failed 5,867 5,861 -6
Panics 2 2 0
Conformance 75.40% 75.41% +0.01%
Fixed tests (6):
test/language/statements/if/cptn-else-false-nrml.js [strict mode] (previously Failed)
test/language/statements/if/cptn-else-false-nrml.js (previously Failed)
test/language/statements/if/cptn-no-else-true-nrml.js [strict mode] (previously Failed)
test/language/statements/if/cptn-no-else-true-nrml.js (previously Failed)
test/language/statements/if/cptn-else-true-nrml.js [strict mode] (previously Failed)
test/language/statements/if/cptn-else-true-nrml.js (previously Failed)

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #2739 (823028a) into main (8d16940) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
+ Coverage   50.16%   50.28%   +0.11%     
==========================================
  Files         400      399       -1     
  Lines       40164    40044     -120     
==========================================
- Hits        20149    20135      -14     
+ Misses      20015    19909     -106     
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/statement/if.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/mod.rs 94.11% <100.00%> (ø)

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Razican
Copy link
Member

Razican commented Mar 25, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 25, 2023
This Pull Request changes the following:

- Adjust if statement execution to leave their resulting values on the stack when needed.
@bors
Copy link

bors bot commented Mar 25, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make if statements return their completion values [Merged by Bors] - Make if statements return their completion values Mar 25, 2023
@bors bors bot closed this Mar 25, 2023
@bors bors bot deleted the if-expr-return branch March 25, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants