[Merged by Bors] - Fix update expressions getting values multiple times #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
bug
Test262 conformance changes
Fixed tests (8): |
Codecov Report
@@ Coverage Diff @@
## main #2733 +/- ##
==========================================
+ Coverage 50.21% 50.31% +0.10%
==========================================
Files 401 400 -1
Lines 40034 40011 -23
==========================================
+ Hits 20103 20133 +30
+ Misses 19931 19878 -53
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HalidOdat
approved these changes
Mar 24, 2023
raskad
requested review from
jasonwilliams,
jedel1043,
nekevss,
RageKnify and
Razican
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 25, 2023
Currently update expressions get values multiple times. This can lead to multiple executions of object property getters. This is very similar to #2551. Unfortunateley it seems like we have to sacrifice some code duplication for correctness in these cases. But that is probably for the best, as we can generate more optimized bytecode for each of these `get/set` cases.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently update expressions get values multiple times. This can lead to multiple executions of object property getters.
This is very similar to #2551. Unfortunateley it seems like we have to sacrifice some code duplication for correctness in these cases. But that is probably for the best, as we can generate more optimized bytecode for each of these
get/setcases.