Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove panics on module compilation #2730

Closed
wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Member

This Pull Request fixes the current panics on module compilation to prepare for the next release.

@jedel1043 jedel1043 added execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine. labels Mar 23, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Mar 23, 2023
@github-actions
Copy link

github-actions bot commented Mar 23, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,078 71,078 0
Ignored 17,324 17,324 0
Failed 5,875 5,875 0
Panics 14 2 -12
Conformance 75.39% 75.39% 0.00%
Fixed panics (12):
test/language/module-code/instn-resolve-order-src.js [strict mode] (previously Panic)
test/language/module-code/instn-resolve-order-src.js (previously Panic)
test/language/module-code/instn-resolve-err-syntax-1.js [strict mode] (previously Panic)
test/language/module-code/instn-resolve-err-syntax-1.js (previously Panic)
test/language/module-code/instn-resolve-err-syntax-2.js [strict mode] (previously Panic)
test/language/module-code/instn-resolve-err-syntax-2.js (previously Panic)
test/language/module-code/instn-resolve-empty-import.js [strict mode] (previously Panic)
test/language/module-code/instn-resolve-empty-import.js (previously Panic)
test/language/module-code/instn-resolve-empty-export.js [strict mode] (previously Panic)
test/language/module-code/instn-resolve-empty-export.js (previously Panic)
test/language/module-code/instn-resolve-order-depth.js [strict mode] (previously Panic)
test/language/module-code/instn-resolve-order-depth.js (previously Panic)

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2730 (3197aa7) into main (e465743) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2730      +/-   ##
==========================================
+ Coverage   50.21%   50.25%   +0.04%     
==========================================
  Files         401      397       -4     
  Lines       40034    39995      -39     
==========================================
- Hits        20103    20101       -2     
+ Misses      19931    19894      -37     
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/module.rs 0.00% <0.00%> (ø)
boa_tester/src/exec/mod.rs 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043 jedel1043 marked this pull request as draft March 23, 2023 18:33
@jedel1043 jedel1043 marked this pull request as ready for review March 23, 2023 18:41
@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 23, 2023
This Pull Request fixes the current panics on module compilation to prepare for the next release.
@bors
Copy link

bors bot commented Mar 23, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove panics on module compilation [Merged by Bors] - Remove panics on module compilation Mar 23, 2023
@bors bors bot closed this Mar 23, 2023
@bors bors bot deleted the module-panics branch March 23, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants