-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Remove panics on module compilation #2730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
execution
Issues or PRs related to code execution
vm
Issues and PRs related to the Boa Virtual Machine.
labels
Mar 23, 2023
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
March 23, 2023 18:16
Test262 conformance changes
Fixed panics (12):
|
Codecov Report
@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
+ Coverage 50.21% 50.25% +0.04%
==========================================
Files 401 397 -4
Lines 40034 39995 -39
==========================================
- Hits 20103 20101 -2
+ Misses 19931 19894 -37
... and 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
force-pushed
the
module-panics
branch
from
March 23, 2023 18:41
ad6095f
to
3197aa7
Compare
nekevss
approved these changes
Mar 23, 2023
HalidOdat
approved these changes
Mar 23, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
This Pull Request fixes the current panics on module compilation to prepare for the next release.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Remove panics on module compilation
[Merged by Bors] - Remove panics on module compilation
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the current panics on module compilation to prepare for the next release.