[Merged by Bors] - Improve tester display for multiple editions #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Codecov Report
@@ Coverage Diff @@
## main #2720 +/- ##
==========================================
+ Coverage 49.14% 50.19% +1.04%
==========================================
Files 400 400
Lines 39858 39981 +123
==========================================
+ Hits 19590 20069 +479
+ Misses 20268 19912 -356
... and 44 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Test262 conformance changes
|
Razican
reviewed
Mar 22, 2023
ZackMitkin
reviewed
Mar 22, 2023
HalidOdat
approved these changes
Mar 22, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
This Pull Request improves our test results display per edition and cleanups our edition detector logic. It changes the following: - Adds a new `edition` flag to limit the maximum edition that will be tested. - Adds a new `versioned` flag to display all tested editions in a table. - Adds utility methods to `SpecEdition` to detect the edition of a test and get all the available editions. - Cleanups logic. Output with this PR ~(We only collect ES5, ES6 and ES13 stats, so all other editions are a WIP)~:  ~Marking as a draft since I need to determine the version of the remaining features, but feel free to review everything else.~ Finished!
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
Small display bug introduced by #2720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request improves our test results display per edition and cleanups our edition detector logic.
It changes the following:
editionflag to limit the maximum edition that will be tested.versionedflag to display all tested editions in a table.SpecEditionto detect the edition of a test and get all the available editions.Output with this PR
(We only collect ES5, ES6 and ES13 stats, so all other editions are a WIP):Marking as a draft since I need to determine the version of the remaining features, but feel free to review everything else.Finished!