Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix incorrect Number.MIN_VALUE value #2682

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix incorrect Number.MIN_VALUE value #2682

wants to merge 2 commits into from

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Mar 16, 2023 •
edited
Loading

This will fix the remaining test of the multiplication and division test suite

It changes the following:

  • Change Number.MIN_VALUE from f64::MIN_POSITIVE to 5e-324 value

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Mar 16, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Mar 16, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,994 71,998 +4
Ignored 17,324 17,324 0
Failed 4,959 4,955 -4
Panics 14 14 0
Conformance 76.36% 76.37% +0.00%
Fixed tests (4): 
test/language/expressions/multiplication/S11.5.1_A4_T7.js [strict mode] (previously Failed)
test/language/expressions/multiplication/S11.5.1_A4_T7.js (previously Failed)
test/language/expressions/division/S11.5.2_A4_T10.js [strict mode] (previously Failed)
test/language/expressions/division/S11.5.2_A4_T10.js (previously Failed)

@HalidOdat HalidOdat marked this pull request as ready for review March 16, 2023 21:14
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #2682 (bf7d429) into main (2588aa9) will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
+ Coverage   49.22%   49.53%   +0.30%     
==========================================
  Files         396      394       -2     
  Lines       39707    39430     -277     
==========================================
- Hits        19547    19530      -17     
+ Misses      20160    19900     -260
Impacted Files Coverage Δ
boa_engine/src/builtins/number/mod.rs 81.60% <ø> (ø)

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raskad
Copy link
Member

raskad commented Mar 16, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 16, 2023
@HalidOdat
Fix incorrect Number.MIN_VALUE value (#2682)
4d121e5 
This will fix the remaining test of the `multiplication` and `division` test suite

It changes the following:
- Change `Number.MIN_VALUE` from `f64::MIN_POSITIVE` to `5e-324` value
@bors
Copy link

bors bot commented Mar 16, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix incorrect Number.MIN_VALUE value [Merged by Bors] - Fix incorrect Number.MIN_VALUE value Mar 16, 2023
@bors bors bot closed this Mar 16, 2023
@bors bors bot deleted the fix/Number.MIN_VALUE branch March 16, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@raskad raskad raskad approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @raskad @jedel1043