[Merged by Bors] - [regexp] new tests for unicode flag #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
test
Codecov Report
@@ Coverage Diff @@
## main #2656 +/- ##
==========================================
+ Coverage 49.20% 49.59% +0.38%
==========================================
Files 390 383 -7
Lines 39562 39228 -334
==========================================
- Hits 19467 19454 -13
+ Misses 20095 19774 -321 see 17 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
requested review from
jedel1043,
raskad,
HalidOdat,
jasonwilliams,
nekevss,
RageKnify and
Razican
raskad
approved these changes
Mar 13, 2023
the flag got introduced in regress 0.5.0
selfisekai
force-pushed
the
regress-unicode
branch
from
22ac3f4 to
97ea03d
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
the flag got introduced in regress 0.5.0 <!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request fixes/closes: n/a. It changes the following: - add test for unicode flag - add test for native error on failing to parse (got removed in #2651 because the previous example parsing correctly now) Co-authored-by: Lauren N. Liberda <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the flag got introduced in regress 0.5.0
This Pull Request fixes/closes: n/a.
It changes the following: