Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: RUSTSEC-2020-0071 in boa_engine #2627

Closed

Conversation

hanabi1224
Copy link
Contributor

This Pull Request fixes/closes #1671

It changes the following:

cargo tree -p boa_engine | grep time
before:

│   ├── iana-time-zone v0.1.53
│   └── time v0.1.45
│       │       └── toml_datetime v0.5.1

after:

│   ├── iana-time-zone v0.1.53
│       │       └── toml_datetime v0.5.1

@jedel1043 jedel1043 added dependencies Pull requests that update a dependency file Internal Category for changelog labels Mar 2, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #2627 (74c904e) into main (23d1aa8) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2627      +/-   ##
==========================================
+ Coverage   49.48%   49.57%   +0.08%     
==========================================
  Files         387      384       -3     
  Lines       39216    39130      -86     
==========================================
- Hits        19407    19398       -9     
+ Misses      19809    19732      -77     
Impacted Files Coverage Δ
boa_engine/src/builtins/array/array_iterator.rs 78.72% <0.00%> (-4.26%) ⬇️
boa_engine/src/builtins/iterable/mod.rs 73.91% <0.00%> (-0.73%) ⬇️
boa_engine/src/builtins/json/mod.rs 83.77% <0.00%> (-0.59%) ⬇️
boa_engine/src/builtins/array/mod.rs 74.29% <0.00%> (-0.38%) ⬇️
boa_engine/src/object/mod.rs 29.13% <0.00%> (-0.11%) ⬇️
boa_examples/src/bin/symbol_visitor.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/jsarraybuffer.rs
boa_examples/src/bin/jsregexp.rs
boa_examples/src/bin/jsset.rs
...arser/src/parser/expression/left_hand_side/call.rs 53.84% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! :)

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix as well! 😄

@nekevss
Copy link
Member

nekevss commented Mar 2, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 2, 2023
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request fixes/closes #1671

It changes the following:

- This PR tries to fix https://rustsec.org/advisories/RUSTSEC-2020-0071 in `boa_engine` crate by removing `time 0.1` from the dependency tree

`cargo tree -p boa_engine | grep time`
before:
```console
│   ├── iana-time-zone v0.1.53
│   └── time v0.1.45
│       │       └── toml_datetime v0.5.1
```
after:
```console
│   ├── iana-time-zone v0.1.53
│       │       └── toml_datetime v0.5.1
```
@bors
Copy link

bors bot commented Mar 2, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title fix: RUSTSEC-2020-0071 in boa_engine [Merged by Bors] - fix: RUSTSEC-2020-0071 in boa_engine Mar 2, 2023
@bors bors bot closed this Mar 2, 2023
@hanabi1224 hanabi1224 deleted the fix-rustsec-2020-0071-boa_engine branch March 2, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0071: Potential segfault in the time crate
3 participants