Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Keep Integer type for inc/dec of an integer #2615

Closed
wants to merge 1 commit into from

Conversation

tunz
Copy link
Contributor

@tunz tunz commented Feb 21, 2023

Keep Integer type after running unary increment/decrement ops if possible. The integer type will be useful to take fast paths for accessing index properties. (e.g., let a = 1; arr[++a])

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #2615 (05f4fee) into main (f8b6820) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
+ Coverage   49.55%   49.57%   +0.02%     
==========================================
  Files         385      384       -1     
  Lines       39138    39132       -6     
==========================================
+ Hits        19393    19400       +7     
+ Misses      19745    19732      -13     
Impacted Files Coverage Δ
boa_engine/src/vm/opcode/unary_ops/decrement.rs 82.60% <75.00%> (+7.60%) ⬆️
boa_engine/src/vm/opcode/unary_ops/increment.rs 82.60% <75.00%> (+7.60%) ⬆️
boa_interner/src/lib.rs 82.35% <0.00%> (-1.69%) ⬇️
boa_parser/src/parser/expression/mod.rs 83.40% <0.00%> (-1.35%) ⬇️
boa_engine/src/value/operations.rs 48.59% <0.00%> (-0.63%) ⬇️
boa_examples/src/bin/symbol_visitor.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/modulehandler.rs
boa_examples/src/bin/jsset.rs
boa_examples/src/bin/classes.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HalidOdat HalidOdat added the run-benchmark Label used to run banchmarks on PRs label Feb 23, 2023
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution @tunz

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution 😄

@nekevss nekevss added this to the v0.17.0 milestone Feb 24, 2023
@nekevss
Copy link
Member

nekevss commented Feb 24, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 24, 2023
Keep Integer type after running unary increment/decrement ops if possible. The integer type will be useful to take fast paths for accessing index properties. (e.g., `let a = 1; arr[++a]`)
@bors
Copy link

bors bot commented Feb 24, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Keep Integer type for inc/dec of an integer [Merged by Bors] - Keep Integer type for inc/dec of an integer Feb 24, 2023
@bors bors bot closed this Feb 24, 2023
@tunz tunz deleted the tunz/optimize-unary-inc-dec branch July 18, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmark Label used to run banchmarks on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants