feat: import parsing #259
Closed
feat: import parsing #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afinch7
force-pushed
the
import_parsing
branch
6 times, most recently
from
5372370 to
bc205c5
Compare
|
Thanks for picking this up |
|
You need to rebase |
|
This isn't really spec compliant, but it works fine for the time being. Things like multiple default imports are parsed without error. This example isn't supposed to be valid, but it parses fine: import default, defaultTwo from "./somefile.js";I'm not to concerned with this currently. I would prefer to move on to export parsing and revisit this once module execution works. |
Razican
added
enhancement
|
Hi! The parser has changed a lot after #281. Would it be possible to rebase? |
|
pings @afinch7 we may have to close this PR if it becomes inactive |
Not perfectly spec compliant yet, but should be close enough until import execution is implemented.
|
I should have some time this week to get this completely rebased. |
|
I haven't been able to find the time to rebase this right now. I'm closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple import statement parsing. I intend to follow this up with some execution implementation.