[Merged by Bors] - Implement WeakSet
#2586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
enhancement
Test262 conformance changes
Fixed tests (180): |
raskad
requested review from
jedel1043,
HalidOdat,
jasonwilliams,
nekevss,
RageKnify and
Razican
Codecov Report
@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
- Coverage 49.38% 48.86% -0.52%
==========================================
Files 381 393 +12
Lines 37906 39061 +1155
==========================================
+ Hits 18720 19089 +369
- Misses 19186 19972 +786
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
reviewed
Feb 3, 2023
There was a problem hiding this comment.
Thanks for the preliminar work! Though, this implementation has the problem of not freeing the inner EphemeronBox when the inner value invalidates. I think this could only be solved by creating a WeakMap structure with direct support from our GC. The GC would then track every WeakMap to free the invalidated boxes from the map.
Anyways, I think we could technically merge this as it is and improve the design later, but let me know what you think first :)
Comment on lines
80
to
95
| /// Insert the value into the set. | ||
| pub fn add(&mut self, value: &JsObject) -> bool { | ||
| self.inner.insert(WeakSetObject(WeakGc::new(value.inner()))) | ||
| } | ||
|
|
||
| /// Remove the value from the set, and return `true` if it was present. | ||
| pub fn delete(&mut self, value: &JsObject) -> bool { | ||
| self.inner | ||
| .shift_remove(&WeakSetObject(WeakGc::new(value.inner()))) | ||
| } | ||
|
|
||
| /// Return `true` if an equivalent to value exists in the set. | ||
| pub fn contains(&self, value: &JsObject) -> bool { | ||
| self.inner | ||
| .contains(&WeakSetObject(WeakGc::new(value.inner()))) | ||
| } |
There was a problem hiding this comment.
I think implementing a special HashMap using ephemerons directly in our GC would avoid having to create a WeakSetObject on each access.
Yes I was thinking the same thing, but I'm not sure where exactly that would fit in our gc process and how much we would have to adjust it. My first instinct is that we would want to check for any collected weak refs in |
Probably by doing something similar as the strong pointers: a queue of |
|
@jedel1043 I implemented a |
jedel1043
reviewed
Feb 9, 2023
| /// A map that holds weak references to its keys and is traced by the garbage collector. | ||
| #[derive(Clone, Debug, Default, Trace, Finalize)] | ||
| pub struct WeakMap<K: Trace + Sized + 'static, V: Trace + Sized + 'static> { | ||
| pub(crate) inner: Gc<GcRefCell<HashMap<WeakGc<K>, V>>>, |
There was a problem hiding this comment.
While this works, I think it would be better to directly use a HashSet<Ephemeron<K, V>> to optimize this, since right now it is using an Ephemeron<K, ()> and a V.
There was a problem hiding this comment.
Hm, realized that to do this we'll probably have to implement our own HashMap...
There was a problem hiding this comment.
Yeah, this should work for now. Maybe in the future we'll have to inline HashMap to optimize the memory of this.
jedel1043
reviewed
Feb 9, 2023
jedel1043
approved these changes
Feb 9, 2023
nekevss
reviewed
Feb 10, 2023
nekevss
approved these changes
Feb 11, 2023
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
WeakSetbuildin object.WeakSetobject #2009