Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix rust 1.67 lints #2567

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix rust 1.67 lints #2567

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 26, 2023

This Pull Request changes the following:

  • Fix rust 1.67 lints

@raskad raskad added the rust Pull requests that update Rust code label Jan 26, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,686 70,686 0
Ignored 18,622 18,622 0
Failed 4,897 4,897 0
Panics 0 0 0
Conformance 75.03% 75.03% 0.00%

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #2567 (b5b7f88) into main (753cab6) will decrease coverage by 0.02%.
The diff coverage is 48.48%.

@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
- Coverage   50.02%   50.01%   -0.02%     
==========================================
  Files         380      380              
  Lines       37798    37786      -12     
==========================================
- Hits        18910    18898      -12     
  Misses      18888    18888              
Impacted Files Coverage Δ
boa_ast/src/lib.rs 75.00% <ø> (ø)
boa_engine/src/builtins/function/mod.rs 29.97% <0.00%> (-0.09%) ⬇️
boa_engine/src/builtins/intl/collator/mod.rs 6.46% <0.00%> (ø)
boa_engine/src/builtins/intl/collator/options.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/intl/date_time_format.rs 4.59% <0.00%> (ø)
boa_engine/src/builtins/intl/list_format/mod.rs 7.73% <0.00%> (ø)
boa_engine/src/builtins/intl/locale/options.rs 0.00% <ø> (ø)
boa_engine/src/builtins/intl/options.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/regexp/mod.rs 66.19% <0.00%> (+0.10%) ⬆️
boa_engine/src/job.rs 58.97% <ø> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nekevss
Copy link
Member

nekevss commented Jan 27, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 27, 2023
This Pull Request changes the following:

- Fix rust 1.67 lints
@bors
Copy link

bors bot commented Jan 27, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix rust 1.67 lints [Merged by Bors] - Fix rust 1.67 lints Jan 27, 2023
@bors bors bot closed this Jan 27, 2023
@bors bors bot deleted the rust-1.67 branch January 27, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants