[Merged by Bors] - Avoid creating prototype property on methods
#2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
bug
Test262 conformance changes
Fixed tests (10): |
Codecov Report
@@ Coverage Diff @@
## main #2553 +/- ##
==========================================
+ Coverage 49.99% 50.21% +0.22%
==========================================
Files 379 376 -3
Lines 37642 37478 -164
==========================================
+ Hits 18819 18821 +2
+ Misses 18823 18657 -166
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
requested review from
jedel1043,
nekevss,
HalidOdat,
jasonwilliams,
RageKnify and
Razican
nekevss
reviewed
Jan 23, 2023
| @@ -138,6 +138,7 @@ impl ByteCompiler<'_, '_> { | |||
| let index = self.code_block.functions.len() as u32; | |||
| self.code_block.functions.push(code); | |||
| self.emit(Opcode::GetFunction, &[index]); | |||
| self.emit_u8(0); | |||
There was a problem hiding this comment.
Thoughts on creating an emit method like emit_with_opcode_and_u8 (maybe not the best name) to bind the pushing of the two operands together?
Edit: maybe even better emit_opcode_with_operand_and_bool, it's a long name, but then you can feed index and true/false as the arguments.
There was a problem hiding this comment.
I think we could maybe generate emit functions for every opcode via a macro e.g. Opcode::GetFunction::emit. These functions could then automatically take the correct arguments.
Do we want to create a dedicated issue for making bytecode generation more typesafe?
There was a problem hiding this comment.
Yeah, that would make sense to me. Submitted an issue #2561 😄
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
This Pull Request changes the following: - Stop creating a `prototype` property on class methods by passing a flag to the relevant opcodes.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
prototype property on methodsprototype property on methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
prototypeproperty on class methods by passing a flag to the relevant opcodes.